Add unit test for fips metadata attribute in enroll/checkin #4514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
Team:Elastic-Agent-Control-Plane
|
blakerouse
approved these changes
Feb 26, 2025
swiatekm
approved these changes
Feb 26, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
(cherry picked from commit ba68a24)
mergify bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
(cherry picked from commit ba68a24)
This was referenced Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Add unit tests as a sanity check to make sure that fleet-server is able to handle the new
fipsmetadata attribute.fleet-server uses
json.RawMessagewhen interacting with local metadata (in the enroll and checkin endpoints) as it just needs to compare byte values to see if the agent doc needs to be changed. The new tests verify that local metadata changes are propagated as expected.Design Checklist
I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.